Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(configs): Adjust file based configs #3171

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Conversation

sanekmelnikov
Copy link
Collaborator

What ❔

  • Add fields to mainnet.yaml so that zkstack can create mainnet ecosystem
  • Add comment about typo in max_acceptable_priority_fee_in_gwei (caused problems before)
  • Add l1_batch_min_age_before_execute_seconds to avoid sending Execute tx too early

Why ❔

  • To make things work

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

@Deniallugo Deniallugo added this pull request to the merge queue Oct 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 25, 2024
@perekopskiy perekopskiy changed the title fix(configs): Adjust file based configs chore(configs): Adjust file based configs Oct 25, 2024
@perekopskiy perekopskiy added this pull request to the merge queue Oct 25, 2024
Merged via the queue into main with commit 91ec341 Oct 25, 2024
44 checks passed
@perekopskiy perekopskiy deleted the sanekmelnikov/overrides branch October 25, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants